Simplify ComplexRampPhasor#4239
Merged
christiankral merged 1 commit intomodelica:masterfrom Dec 13, 2023
Merged
Conversation
HansOlsson
added
bug
AHaumer
approved these changes
Dec 12, 2023
Contributor
AHaumer
left a comment
AHaumer
left a comment
There was a problem hiding this comment.
as discussed in MAP-Lib monthly 2023-12-12
dietmarw
force-pushed
the
ComplexRamp2
branch
from
ab37e50 to
b88bed8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on comments in #4156 just remove eps.
The problem with eps is that it is a relative precision, so max(duration, eps) doesn't work well, but we don't have a good time-scale so eps*abs(startTime) will also fail.
I found it clearer to have two different PRs to chose from.