Add resource_templates to MCP::Client#225
Open
sjrct wants to merge 3 commits intomodelcontextprotocol:mainfrom
Open
Add resource_templates to MCP::Client#225sjrct wants to merge 3 commits intomodelcontextprotocol:mainfrom
sjrct wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
Also remove unused require from logging_message_notification.rb
Member
|
Looks good to me. Can you squash your commits into one?
Good catch. This removal is outside the scope of the changes intended in this PR, so it would be better to split it into a separate PR if possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for querying resource templates to the MCP::Client
I also removed an unused require from
logging_message_notification.rbMotivation and Context
Prior there was no MCP::Client interface for listing resource templates
How Has This Been Tested?
I tested it with the following script with an mcp server I have:
And added tests to
test/mcp/client_test.rbBreaking Changes
No breaking changes, just the new method
Types of changes
Checklist
Additional context