fix: handle EndOfStream and ClosedResourceError in send_request#1939
Open
kxbnb wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: handle EndOfStream and ClosedResourceError in send_request#1939kxbnb wants to merge 1 commit intomodelcontextprotocol:mainfrom
kxbnb wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Fixes modelcontextprotocol#1717 The `send_request` method only catches `TimeoutError` from the `response_stream_reader.receive()` call. If `receive()` raises `EndOfStream` or `ClosedResourceError` (e.g., when the connection closes unexpectedly), these exceptions propagate without being caught, potentially leaving `response_or_error` unassigned and causing an `UnboundLocalError` at the subsequent isinstance check. This adds explicit handling for these stream closure exceptions, converting them to `McpError` with `CONNECTION_CLOSED` error code. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1717
Adds handling for
EndOfStreamandClosedResourceErrorinsend_request(). These exceptions can be raised byresponse_stream_reader.receive()but weren't being caught, leading toUnboundLocalErrorat the subsequentisinstancecheck.Changes
except (anyio.EndOfStream, anyio.ClosedResourceError)block after the existingTimeoutErrorhandlerMcpErrorwithCONNECTION_CLOSEDerror codeValidation
uv run pyrightpasses with 0 errorsTesting
Closes #1717