Fix and extend anonymize_info#13647
Merged
larsoner merged 6 commits intomne-tools:mainfrom Feb 10, 2026
Merged
Conversation
Contributor
Author
|
In which category should I create the corresponding changelog entry? |
Member
|
I think it counts as an enhancement (better control/granularity, no behavior change or deprecation) |
larsoner
approved these changes
Feb 10, 2026
Member
larsoner
left a comment
There was a problem hiding this comment.
Just two optional ideas other than needing a doc/changes/dev/13647.newfeature.rst
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Contributor
Author
|
Thanks @larsoner! Unless I messed up the rST in the changelog entry (chances are >50% 😃), this should be ready to merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13637.
In this PR, I have
keep_hisparameter to acceptTrue,False, and the strings"his_id","sex", and"hand"(or a sequence of any combination of these strings),Importantly, the default behavior doesn't change (
keep_his=False), andkeep_his=Truekeeps the three fields (also as previously, but this time I've documented it correctly).