Skip to content

chore: migrate pydantic to v2, fastapi to 0.129#1067

Draft
SaboniAmine wants to merge 1 commit intomasterfrom
chore/migrate_pydantic_to_v2
Draft

chore: migrate pydantic to v2, fastapi to 0.129#1067
SaboniAmine wants to merge 1 commit intomasterfrom
chore/migrate_pydantic_to_v2

Conversation

@SaboniAmine
Copy link
Member

Description

Please explain the changes you made here.

Related Issue

Please link to the issue this PR resolves: [issue #]

Motivation and Context

Why is this change required? What problem does it solve?

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@inimaz inimaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amine! Maybe we can wait until the auth migration is over to merge this one?

)
AUTH_SERVER_URL = os.environ.get(
"AUTH_SERVER_URL", "https://auth.codecarbon.io/codecarbon"
"AUTH_SERVER_URL", "https://auth.codecarbon.io/codecarbon-dev"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"AUTH_SERVER_URL", "https://auth.codecarbon.io/codecarbon-dev"
"AUTH_SERVER_URL", "https://auth.codecarbon.io/codecarbon"

@SaboniAmine
Copy link
Member Author

Thanks Amine! Maybe we can wait until the auth migration is over to merge this one?

Totally, I opened the draft to be able to review easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants