Include revision in Microsoft-specific version string#2140
Open
dagood wants to merge 1 commit intomicrosoft/mainfrom
Open
Include revision in Microsoft-specific version string#2140dagood wants to merge 1 commit intomicrosoft/mainfrom
dagood wants to merge 1 commit intomicrosoft/mainfrom
Conversation
Member
dagood
commented
Feb 13, 2026
dagood
commented
- Go 1.26.0-1 doesn't include revision in microsoft_toolset_version #2138
dagood
commented
Feb 17, 2026
|
|
||
| func writeDevelVersionFile(goRootDir, executableExtension string) (string, error) { | ||
| // Use "go tool dist version" to directly get the version the toolset would call itself. | ||
| cmd := exec.Command(filepath.Join(goRootDir, "bin", "go"+executableExtension), "tool", "dist", "version") |
Member
Author
There was a problem hiding this comment.
This now runs before the build happens, which doesn't work. I suppose the VERSION file handling actually needs to stay where it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.