gvfs-helper: move prefetch/since tracing to helper #850
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrickstolee
force-pushed
the
prefetch-since
branch
from
e4fa402 to
22cd22e
Compare
Adjust our logging of the prefetch/since data into the server because the client always thinks that the value is zero. Signed-off-by: Derrick Stolee <stolee@gmail.com>
derrickstolee
force-pushed
the
prefetch-since
branch
from
22cd22e to
022ca88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gvfs-helper-client code was logging a prefetch timestamp that was always 0 because nothing on the client side checks the ODB for this value. This tracing is confusing and makes it look like we are always sending a zero timestamp.
Move this tracing to the server so we can actually know the value being sent.
I created this as a
fixup!commit so it will be squashed in the future. The commit I'm fixing doesn't integrate the method call inbuiltin/fetch.c, so to be safe I didn't modify the method prototype. I documented to be clear that we ignore the value.GVFS Protocol.