[AutoPR- Security] Patch glib for CVE-2026-1489 [MEDIUM] #15731
+362
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
mfrw
reviewed
Feb 10, 2026
| +#if g_macro__has_attribute(__always_inline__) | ||
| +/* Guard C++ macro for C compilation */ | ||
| +#ifndef __cplusplus | ||
| +#define G_CXX_STD_CHECK_VERSION(v) (0) |
Member
There was a problem hiding this comment.
The upstream patch does not modify the macro file.
What is our rationale of doing it ?
| * We use a two pass approach to keep memory management simple | ||
| */ | ||
| result_len = real_tolower (str, len, NULL, locale_type); | ||
| + g_assert (result_len < G_MAXSIZE); |
Member
There was a problem hiding this comment.
This patch hunk for guniprop looks good w.r.t upstream.
Also, do we not have the allied test file that is modified in the upstream patch ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto Patch glib for CVE-2026-1489.
Autosec pipeline run -> https://dev.azure.com/mariner-org/mariner/_build/results?buildId=1043778&view=results
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology