Skip to content

Conversation

@aadhar-agarwal
Copy link
Contributor

@aadhar-agarwal aadhar-agarwal commented Feb 4, 2026

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

What does the PR accomplish, why was it needed?

  • This PR upgrades kubevirt to 1.7.0, libvirt to 10.10.0 and QEMU to 9.1.0 to address virt-launcher memory leak affecting NAKS clusters.
Change Log

kubevirt

  • Remove CVE-2025-47913.patch (ssh/agent package no longer vendored upstream)
    • The patch was removed because kubevirt 1.7.0 no longer vendors the vulnerable golang.org/x/crypto/ssh/agent package. The directory was removed in PR #15478 ("cleanup(virtctl): Drop native ssh and scp clients"), which eliminated the native SSH/SCP clients from virtctl and removed the dependency on the vulnerable package entirely.
  • Remove CVE-2025-64435.patch (fixed upstream via PR#15680)
    • The patch was removed because the fix is included upstream in kubevirt 1.7.0 via PR #15680. The vulnerable pkg/controller/controller_ref.go file no longer exists in 1.7.0 - it was completely removed and replaced with secure standard Kubernetes API calls.
  • Bump golang BuildRequires to >= 1.24 (required by upstream go.mod)
    • The BuildRequires: golang >= 1.24 change is required because kubevirt 1.7.0 updated its Go version via PR #15784: "Build KubeVirt with go v1.24.7". The project's go.mod now declares go 1.24.0, making Go 1.24+ mandatory for building.

libvirt

Does this affect the toolchain?

NO

Associated memory leak fixes
Test Methodology

@aadhar-agarwal aadhar-agarwal changed the base branch from 3.0 to 3.0-dev February 4, 2026 01:38
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED Tools 3.0-dev PRs Destined for AzureLinux 3.0 labels Feb 4, 2026
@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/upgrade-kubevirt-1.7 branch from baf00af to 9139554 Compare February 4, 2026 01:43
- Remove CVE-2025-47913.patch (ssh/agent package no longer vendored)
- Remove CVE-2025-64435.patch (fixed upstream via PR#15680)
- Bump golang BuildRequires to >= 1.24 per upstream PR#15784

Signed-off-by: Aadhar Agarwal <aadagarwal@microsoft.com>
@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/upgrade-kubevirt-1.7 branch from 9139554 to c9b4e2c Compare February 4, 2026 02:03
@harshitgupta1337
Copy link
Contributor

/lgtm
Thanks @aadhar-agarwal

@aadhar-agarwal aadhar-agarwal changed the title Upgrade kubevirt to 1.7.0 Upgrade kubevirt to 1.7.0 and backport libvirt GSource memory leak fix Feb 4, 2026
@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/upgrade-kubevirt-1.7 branch 6 times, most recently from c031501 to def3369 Compare February 6, 2026 20:34
@aadhar-agarwal aadhar-agarwal changed the title Upgrade kubevirt to 1.7.0 and backport libvirt GSource memory leak fix Upgrade kubevirt to 1.7.0 and Upgrade libvirt to 10.10.0 Feb 6, 2026
@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/upgrade-kubevirt-1.7 branch 5 times, most recently from 49db930 to 084a9af Compare February 6, 2026 22:24
- Upgrade from 10.0.0 to 10.10.0 for kubevirt 1.7.0 compatibility
- Remove CVE-2024-1441, CVE-2024-2494, CVE-2024-4418 patches (fixed upstream)
- Remove rpc-gsource-leak-virnetclientio.patch (fixed upstream)
- Switch from yajl to json-c (required since libvirt 10.8.0)
- Update sha256 signature for new tarball
@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/upgrade-kubevirt-1.7 branch from 084a9af to 1628604 Compare February 6, 2026 23:32
@aadhar-agarwal aadhar-agarwal changed the title Upgrade kubevirt to 1.7.0 and Upgrade libvirt to 10.10.0 Upgrade kubevirt to 1.7.0, Upgrade libvirt to 10.10.0 and QEMU to 9.1.0 Feb 7, 2026
@aadhar-agarwal aadhar-agarwal changed the title Upgrade kubevirt to 1.7.0, Upgrade libvirt to 10.10.0 and QEMU to 9.1.0 Upgrade kubevirt to 1.7.0, libvirt to 10.10.0 and QEMU to 9.1.0 Feb 7, 2026
@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/upgrade-kubevirt-1.7 branch 4 times, most recently from d9551af to 029a230 Compare February 9, 2026 01:03
@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/upgrade-kubevirt-1.7 branch 8 times, most recently from ef21374 to 2827056 Compare February 9, 2026 19:25
- Remove CVE patches merged upstream: CVE-2023-6683, CVE-2023-6693,
  CVE-2024-3447, CVE-2024-4467, CVE-2024-6505, CVE-2024-4693,
  CVE-2024-7730, CVE-2024-3567, CVE-2024-26327, CVE-2024-26328,
  CVE-2024-7409
- Rebase 0002-Disable-failing-tests-on-azl.patch for 9.1.0
- Remove live-block-migration configure options (removed upstream in
  commit eef0bae3a75f "migration: Remove block migration")
@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/upgrade-kubevirt-1.7 branch from 2827056 to 256f885 Compare February 9, 2026 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging specs-extended PR to fix SPECS-EXTENDED Tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants