Python: during package checks don't always allow continue on failure#4519
Open
moonbox3 wants to merge 3 commits intomicrosoft:mainfrom
Open
Python: during package checks don't always allow continue on failure#4519moonbox3 wants to merge 3 commits intomicrosoft:mainfrom
moonbox3 wants to merge 3 commits intomicrosoft:mainfrom
Conversation
|
|
||
| [tool.pyright] | ||
| extends = "../../pyproject.toml" | ||
| include = ["agent_framework", "tests/workflow"] |
Member
There was a problem hiding this comment.
I already had this in my PR, was that wiped out?
eavanvalkenburg
approved these changes
Mar 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Tightens Python code-quality enforcement by expanding pyright coverage to include core package sources and ensuring CI jobs fail on code-quality errors rather than continuing.
Changes:
- Expand
pyrightincludepaths to coveragent_frameworkin the core package. - Remove
continue-on-error: truefrom Python code quality workflow jobs so failures stop CI.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| python/packages/core/pyproject.toml | Expands pyright coverage beyond workflow tests to include core package sources. |
| .github/workflows/python-code-quality.yml | Makes code-quality failures fail the workflow by removing job-level continue-on-error. |
You can also share your feedback on Copilot code review. Take the survey.
Member
Python Test Coverage Report •
Python Unit Test Overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Previously not all core packages were included in the pyright check. Additionally, if a failure occurs in CI/CD, we continued on error. We want to make sure we don't mask any errors.
Description
Contribution Checklist