fix(lib): allow 'default' in Intl.CollatorOptions.collation#62982
Closed
adityavyas01 wants to merge 2 commits intomicrosoft:mainfrom
Closed
fix(lib): allow 'default' in Intl.CollatorOptions.collation#62982adityavyas01 wants to merge 2 commits intomicrosoft:mainfrom
adityavyas01 wants to merge 2 commits intomicrosoft:mainfrom
Conversation
typescript-bot
added
the
For Uncommitted Bug
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a type definition issue in the Intl.CollatorOptions interface by adding the missing 'default' literal value to the collation property, aligning the TypeScript type definitions with the actual runtime behavior of the Intl.Collator API.
Changes:
- Added 'default' as a valid collation option in Intl.CollatorOptions
- Added test case to verify 'default' collation value is accepted
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/lib/es5.d.ts | Added 'default' literal to collation property type definition |
| tests/cases/conformance/es2020/localesObjectArgument.ts | Added test case using 'default' collation value |
Member
|
Your fixes line is just a link to another PR with the same contents |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62971
Adds the missing 'default' literal to Intl.CollatorOptions.collation
to match runtime behavior.