Improvement: added shapes to DatasetDefinition#7891
Open
esbenh4 wants to merge 4 commits intomicrosoft:mainfrom
Open
Improvement: added shapes to DatasetDefinition#7891esbenh4 wants to merge 4 commits intomicrosoft:mainfrom
esbenh4 wants to merge 4 commits intomicrosoft:mainfrom
Conversation
…ent. extended tests to cover new uses.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7891 +/- ##
==========================================
- Coverage 59.94% 59.94% -0.01%
==========================================
Files 352 352
Lines 31933 31937 +4
==========================================
+ Hits 19143 19145 +2
- Misses 12790 12792 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
jenshnielsen
reviewed
Mar 2, 2026
jenshnielsen
reviewed
Mar 2, 2026
Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
Co-authored-by: Jens Hedegaard Nielsen <jenshnielsen@gmail.com>
Contributor
|
This implementation looks sound to me, but I do have a question: What happens if the shape specified here does not match what ends up being actually recorded? e.g. if I specify a DataSetDefinition that includes 11 B-Field points, but I actually take 13, when does the error occur? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabled use of shape in DatasetDefinition to set shape of measurement when using datasaver_builder to create measurements.