Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the project’s Python packaging and developer tooling configuration by moving requirements and build metadata into pyproject.toml, tightening static analysis settings, and aligning the codebase with lint expectations (module-level docstrings).
Changes:
- Migrate dev/test dependency management from
dev_requirements.txt/tests/requirements.txtintopyproject.tomlextras and update CI installation accordingly. - Remove legacy packaging files (
setup.py,MANIFEST.in) and switch to dynamic versioning viafeaturemanagement._version.VERSION. - Add module-level docstrings across the package and set mypy to fully strict mode.
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/requirements.txt | Removes standalone test requirements file (moved to extras). |
| setup.py | Removes legacy setuptools script in favor of pyproject.toml. |
| pyproject.toml | Centralizes tooling config, build metadata, dynamic version, and dev/test extras. |
| mypy.ini | Switches mypy configuration to strict = True. |
| featuremanagement/azuremonitor/_send_telemetry.py | Adds module docstring. |
| featuremanagement/azuremonitor/init.py | Adds module docstring. |
| featuremanagement/aio/_featuremanager.py | Adds module docstring. |
| featuremanagement/aio/_featurefilters.py | Adds module docstring. |
| featuremanagement/aio/_defaultfilters.py | Adds module docstring. |
| featuremanagement/aio/init.py | Adds module docstring. |
| featuremanagement/_version.py | Adds module docstring (supports dynamic version source). |
| featuremanagement/_time_window_filter/_recurrence_validator.py | Adds module docstring. |
| featuremanagement/_time_window_filter/_recurrence_evaluator.py | Adds module docstring. |
| featuremanagement/_time_window_filter/_models.py | Adds module docstring. |
| featuremanagement/_time_window_filter/init.py | Adds module docstring. |
| featuremanagement/_models/_variant_reference.py | Adds module docstring. |
| featuremanagement/_models/_variant_assignment_reason.py | Adds module docstring. |
| featuremanagement/_models/_variant.py | Adds module docstring. |
| featuremanagement/_models/_telemetry.py | Adds module docstring. |
| featuremanagement/_models/_targeting_context.py | Adds module docstring. |
| featuremanagement/_models/_feature_flag.py | Adds module docstring. |
| featuremanagement/_models/_feature_conditions.py | Adds module docstring. |
| featuremanagement/_models/_evaluation_event.py | Adds module docstring. |
| featuremanagement/_models/_constants.py | Adds module docstring. |
| featuremanagement/_models/_allocation.py | Adds module docstring. |
| featuremanagement/_models/init.py | Adds module docstring. |
| featuremanagement/_featuremanagerbase.py | Adds module docstring. |
| featuremanagement/_featuremanager.py | Adds module docstring. |
| featuremanagement/_featurefilters.py | Adds module docstring. |
| featuremanagement/_defaultfilters.py | Adds module docstring. |
| featuremanagement/init.py | Adds module docstring. |
| dev_requirements.txt | Removes standalone dev requirements file (moved to extras). |
| cspell.config.yaml | Updates ignored paths to reflect removed files / typical dirs. |
| MANIFEST.in | Removes legacy manifest configuration. |
| .github/workflows/validate.yml | Installs dependencies via pyproject.toml extras instead of requirements files. |
| .github/copilot-instructions.md | Adds repo-specific contributor/Copilot guidance for tooling and conventions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 51 out of 51 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rossgrambo
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Only makes dev/build updates, besides adding module level doc strings.
Contribution checklist:
General Guidelines and Best Practices