-
Notifications
You must be signed in to change notification settings - Fork 378
save and load max_record_size and leaf_page_size for bftrees #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the BfTree save/load functionality by adding support for persisting and restoring the max_record_size and leaf_page_size configuration parameters. This builds upon previously implemented save/load infrastructure and leverages new getter functions available in bftree version 0.4.7.
Changes:
- Introduced
BfTreeParamsstruct to encapsulate BfTree configuration parameters (bytes, max_record_size, leaf_page_size) - Updated
SavedParamsandQuantParamsto useBfTreeParamsinstead of simpleusizevalues - Modified load functions to restore BfTree configurations with saved max_record_size and leaf_page_size values
- Updated tests to demonstrate save/load of BfTree configurations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #724 +/- ##
==========================================
- Coverage 89.01% 89.00% -0.02%
==========================================
Files 428 428
Lines 78151 78235 +84
==========================================
+ Hits 69566 69630 +64
- Misses 8585 8605 +20
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This is a small PR, which builds upon an internal PR where we started implementing save/load functionality for bftrees. Since we recently bumped up bftree version to 0.4.7, which implements getter functions for max_record_size and leaf_page_size, we can save and load these variables when saving and load bftrees. This is necessary to do because we might need to increase max_record_size and leaf_page_size if the dimensionality of the vectors is too large