Stop special-casing forwarded internal types#2315
Open
Sergio0694 wants to merge 1 commit intostaging/3.0from
Open
Stop special-casing forwarded internal types#2315Sergio0694 wants to merge 1 commit intostaging/3.0from
Sergio0694 wants to merge 1 commit intostaging/3.0from
Conversation
Only forward public top-level types now by removing the previous exception that allowed certain non-public SDK types (System.IO and Windows.Storage.Streams) to be forwarded. This simplifies the filtering logic and removes the IsForwardedInternalType helper and its documentation.
There was a problem hiding this comment.
Pull request overview
This PR simplifies WinRT.Impl.Generator type-forwarding behavior by removing special-casing for selected internal SDK types and forwarding only public top-level types, aligning with the updated stream infrastructure after #2312.
Changes:
- Restrict type forwarding to
exportedType.IsPubliconly (removes internal-namespace exceptions). - Remove the
IsForwardedInternalTypehelper method and its associated documentation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
manodasanW
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only forward public top-level types now by removing the previous exception that allowed certain non-public SDK types (System.IO and Windows.Storage.Streams) to be forwarded. This simplifies the filtering logic and removes the IsForwardedInternalType helper and its documentation. No longer needed after #2312.