[releases/27.5][Shopify] Trial stores with different admin URL cannot connect (#6546)#7124
Open
onbuyuka wants to merge 1 commit intoreleases/27.5from
Open
[releases/27.5][Shopify] Trial stores with different admin URL cannot connect (#6546)#7124onbuyuka wants to merge 1 commit intoreleases/27.5from
onbuyuka wants to merge 1 commit intoreleases/27.5from
Conversation
### Problem When users create Shopify trial stores, Shopify provisions the store with a random internal URL (e.g., `fwlifjsl-rr.myshopify.com`) but displays a different "friendly" URL to the user (e.g., `cable-masters-2.myshopify.com`). During the OAuth flow: 1. User enters the friendly URL they see in Shopify admin 2. OAuth completes successfully, but Shopify returns the **real internal `myshopify_domain`** in the callback 3. The access token gets saved under the internal URL 4. Business Central tries to use the token with the original user-entered URL → **fails with "No access token" error** ### Solution When the store URL returned from Shopify during OAuth differs from what the user entered, prompt the user to correct the store URL. If confirmed, the Shop record is updated to use the actual `myshopify_domain` that Shopify uses internally. ### Changes **ShpfyAuthenticationMgt.Codeunit.al** - Modified `InstallShopifyApp` to accept a `var Shop` parameter - Added store URL mismatch detection after OAuth callback - When mismatch detected, prompts user to correct the URL with confirmation dialog - Fixed typo: `InstalllToStore` → `InstallToStore` **ShpfyShop.Table.al** - Added `SetStoreName(Store: Text)` procedure to update the Shopify URL with validation - Updated `RequestAccessToken()` to pass the Shop record to `InstallShopifyApp` Fixes [AB#621115](https://dynamicssmb2.visualstudio.com/1fcb79e7-ab07-432a-a3c6-6cf5a88ba4a5/_workitems/edit/621115)
darjoo
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When users create Shopify trial stores, Shopify provisions the store with a random internal URL (e.g.,
fwlifjsl-rr.myshopify.com) but displays a different "friendly" URL to the user (e.g.,cable-masters-2.myshopify.com).During the OAuth flow:
myshopify_domainin the callbackSolution
When the store URL returned from Shopify during OAuth differs from what the user entered, prompt the user to correct the store URL. If confirmed, the Shop record is updated to use the actual
myshopify_domainthat Shopify uses internally.Changes
ShpfyAuthenticationMgt.Codeunit.al
InstallShopifyAppto accept avar ShopparameterInstalllToStore→InstallToStoreShpfyShop.Table.al
SetStoreName(Store: Text)procedure to update the Shopify URL with validationRequestAccessToken()to pass the Shop record toInstallShopifyAppFixes
AB#625436