Skip to content

[Shopify] Fix Tax Lines showing all orders when order has no lines#7115

Open
onbuyuka wants to merge 1 commit intomainfrom
bugs/625303-shopify-tax-lines-filter
Open

[Shopify] Fix Tax Lines showing all orders when order has no lines#7115
onbuyuka wants to merge 1 commit intomainfrom
bugs/625303-shopify-tax-lines-filter

Conversation

@onbuyuka
Copy link
Contributor

@onbuyuka onbuyuka commented Mar 12, 2026

Summary

  • When a Shopify order has all lines removed, clicking "Tax Lines" showed tax lines from all orders instead of an empty list
  • Root cause: empty FilterTxt passed to SetFilter removes the filter entirely in AL
  • Fix: when there are no order lines, use SetRange("Parent Id", 0) to ensure no results are returned

Fixes AB#625303

🤖 Generated with Claude Code

When a Shopify order has no lines, the Tax Lines action built an empty
filter which AL interpreted as "no filter", showing tax lines from all
orders. Now sets an impossible filter (Parent Id = 0) so the page shows
no results instead.

Fixes AB#625303

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@onbuyuka onbuyuka requested a review from a team as a code owner March 12, 2026 19:02
@github-actions github-actions bot added the AL: Apps (W1) Add-on apps for W1 label Mar 12, 2026
@onbuyuka onbuyuka enabled auto-merge (squash) March 12, 2026 19:02
@github-actions github-actions bot added this to the Version 29.0 milestone Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants