Provide one text object instead of of two#10
Open
szw wants to merge 2 commits intomichaeljsmith:masterfrom
Open
Provide one text object instead of of two#10szw wants to merge 2 commits intomichaeljsmith:masterfrom
szw wants to merge 2 commits intomichaeljsmith:masterfrom
Conversation
Provide only one text object behaving differently depending on the current filetype. It doesn't include the line below the indent text for file types where indentantion is a part of the syntax. Currently it means Python, CoffeeScript, and Haml buffers. This can be extended as necessary. If accepted the doc/indent-object.txt should be changed accordingly.
Owner
|
Thank you for your commit. I'm not sure what the best way to go about this is. At the moment it's quite easy to make a mapping for the preferred mode for the current file. I'm not necessarily sure that hard-coding a list of file types is the best approach here? If we wanted to go down this route, I think it would make sense to implement the switching as file-type-specific plugins, maybe? |
Author
|
I like the way they did it in vim-pasta plugin: https://github.com/sickill/vim-pasta/blob/master/plugin/pasta.vim#L60 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide only one text object behaving differently depending on the
current filetype. It doesn't include the line below the indent text for
file types where indentantion is a part of the syntax. Currently it
means Python, CoffeeScript, and Haml buffers. This can be extended as
necessary.
If accepted the doc/indent-object.txt should be changed accordingly.