Draft
Conversation
Move ModelSettings, ModelSettingsViewModel, ModelSettingsScreen, FileSelectionRow, FileSelectionDialog, and AsrTheme into a shared Android library at asr/android/shared/. Both apps now consume this via Gradle composite builds (includeBuild). Key design decisions: - ModelSettings uses Whisper's superset (includes preprocessorPath) - DEFAULT_DIRECTORY removed from companion; each app passes its own default directory to the ViewModel via initialize() - ModelSettingsViewModel takes supportsPreprocessor flag to control whether preprocessor files are scanned - ModelSettingsScreen takes showPreprocessor param to conditionally show the preprocessor selection UI - AsrTheme replaces WhisperAppTheme and ParakeetAppTheme - Tests merged (13 ModelSettings tests, 8 ViewModel tests)
Combine both ASR apps into a single app at asr/android/AsrApp/ that supports both Whisper (streaming via AsrModule) and Parakeet (synchronous via ParakeetModule) models. The shared library module is folded directly into the app since there is now only one consumer. Key changes: - Add ModelType enum (WHISPER, PARAKEET) to ModelSettings - Unified download screen with all 7 presets (6 Whisper + 1 Parakeet) - Click-to-toggle recording for both; Whisper gets 30s auto-stop - Whisper token post-processing (strip leading/trailing tokens) - Model type selector in settings screen - Update CI to replace WhisperDemo/ParakeetDemo with AsrDemo - Delete whisper/, parakeet/, and asr/android/shared/ directories
meta-cla
bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.