Remove duplicate executorch submodule, use symlink instead#215
Merged
kirklandsign merged 3 commits intomainfrom Feb 20, 2026
Merged
Remove duplicate executorch submodule, use symlink instead#215kirklandsign merged 3 commits intomainfrom
kirklandsign merged 3 commits intomainfrom
Conversation
Replace the program-data-separation/cpp/executorch submodule (tracking main) with a symlink to third-party/executorch (release/1.0), matching the pattern used by mv2/cpp, mv2/wasm, efficient_sam/wasm, and stories110M/wasm. All CMake build options needed by program-data-separation exist in release/1.0. Saves ~700MB of vendored code and eliminates drift risk between two copies. Update lora and linear example READMEs to reference the shared submodule path and recommend nightly pip install for LoRA export features.
meta-cla
bot
added
the
CLA Signed
lucylq
reviewed
Feb 20, 2026
| ## Install ExecuTorch | ||
|
|
||
| [Install from source](https://docs.pytorch.org/executorch/stable/using-executorch-building-from-source.html#install-executorch-pip-package-from-source): | ||
| Install from a recent nightly build (recommended for LoRA export features): |
Contributor
There was a problem hiding this comment.
I think we can recommend >1.1 now
lucylq
approved these changes
Feb 20, 2026
Contributor
lucylq
left a comment
lucylq
left a comment
There was a problem hiding this comment.
Thank you for updating this!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the program-data-separation/cpp/executorch submodule (tracking main) with a symlink to third-party/executorch (release/1.0), matching the pattern used by mv2/cpp, mv2/wasm, efficient_sam/wasm, and stories110M/wasm. All CMake build options needed by program-data-separation exist in release/1.0. Saves ~700MB of vendored code and eliminates drift risk between two copies.
Update lora and linear example READMEs to reference the shared submodule path and recommend nightly pip install for LoRA export features.