Skip to content

Modify stops on routes for CR-Newburyport and CR-Franklin#964

Open
lemald wants to merge 7 commits intomasterfrom
lem-cr-stops-on-routes
Open

Modify stops on routes for CR-Newburyport and CR-Franklin#964
lemald wants to merge 7 commits intomasterfrom
lem-cr-stops-on-routes

Conversation

@lemald
Copy link
Member

@lemald lemald commented Feb 12, 2026

Summary of changes

Asana Ticket: Review V3 API stop list and order for certain Commuter Rail routes

The details are all in the ticket, but more succinctly, this PR accomplishes three basic changes:

  1. Removing Wonderland and Lynn (non-interim) from CR-Newburyport by excluding the local shuttle from consideration for stops on the route.
  2. Fixing the ordering of Foxboro station on the CR-Franklin line, in both directions.
  3. Making sure that the Fairmount Line stops show up on CR-Franklin by explicitly including the route patterns for Forge Park <-> South Station via Fairmount in consideration.

@lemald lemald changed the title CR stops on routes Modify CR stops on routes for CR-Newburyport and CR-Franklin Feb 12, 2026
@lemald lemald changed the title Modify CR stops on routes for CR-Newburyport and CR-Franklin Modif stops on routes for CR-Newburyport and CR-Franklin Feb 12, 2026
@lemald lemald changed the title Modif stops on routes for CR-Newburyport and CR-Franklin Modify stops on routes for CR-Newburyport and CR-Franklin Feb 12, 2026
@lemald lemald marked this pull request as ready for review February 12, 2026 18:44
@lemald lemald requested a review from a team as a code owner February 12, 2026 18:44
@lemald lemald requested review from jadrian and rudiejd and removed request for a team February 12, 2026 18:44
@rudiejd
Copy link
Member

rudiejd commented Feb 17, 2026

image

1 seems set 👍 .

for 2 and 3: comparing franklin devgreen stops to franklin prod stops - looks like the forge park to south station stops are now included. but this doesn't seem to match the order here - https://www.notion.so/mbta-downtown-crossing/Alerts-Manager-CR-stop-list-order-183f5d8d11ea80429999f95859abc372#2ecf5d8d11ea80acad71f33d26ff31e5?

@lemald
Copy link
Member Author

lemald commented Feb 17, 2026

Weird, the order looks fine if you specify direction_id=0 but it's wrong if you specify direction_id=1, and I don't think there's any material difference in how the two directional stop order overrides work. I'll have to look into it some more.

@lemald
Copy link
Member Author

lemald commented Feb 17, 2026

@rudiejd I ended up taking the option of just specifying the stop ordering for the entire line in direction ID 1 since nothing else was working. Let me know what you think.

@lemald lemald deployed to dev-green February 17, 2026 20:52 — with GitHub Actions Active
@lemald
Copy link
Member Author

lemald commented Feb 17, 2026

Actually, that isn't quite right, it still sorts Hyde Park to the very end despite the overrides. Sorry, I'll have to keep looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants