Closed
Conversation
Co-authored-by: David Stansby <dstansby@gmail.com>
- make LineBaseWidget - make LineWidget for plotting intensities under shapes layer - make FeaturesLineWidget for plotting features from labels layer (grouped by a label column matching labels in layer)
Member
|
Thanks for the clear description, examples and gifs! I like both these a lot, and the code looks good too 👍 . I think I will need to do more thinking about the |
Contributor
Author
|
Alright, I just opened #200 for that, thanks! |
Contributor
Author
|
Closing this, updates can be found in #200 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @dstansby ,
As discussed in a previous #63 , I have updated and re-factored the previous code to add a line widget! 📈 🚀
LineBaseWidgetjust uses plot, similar to theSliceWidget, but without spinboxes. It is used as base by the following classes.LineWidgetuses the Shapes layer to plot intensities from a selected Image layer. So far, it only works with the shapeline. I had to make a small change inbasebecause of this line. I am using thebezier_curvefrom scikit-image to get pixel coordinates. There is no interpolation in this current implementation.FeaturesLineWidgetis similar to theFeaturesScatterWidget, but it has a third dropdown to group plots by a 'label' column.I provided 3 minimal examples and gifs to show how it looks like. I believe the
FeaturesLineWidgetgets interesting, for example, when one has features over time. It also works for single time points, although I think a scatter plot would make more sense then.I am particularly interested in using the LineWidget and the FeaturesLineWidget in other plugins I am working on.
Lastly, I tried to make them minimal and generalizable, but I have some difficulties setting what is minimal 😅 . I think I can count on your experience to help me there.
Best,
Marcelo