Conversation
AltamashShaikh
left a comment
AltamashShaikh
left a comment
There was a problem hiding this comment.
@lachiebol Did you forget to build the vue files and commit them ?
@AltamashShaikh Doh! Should be there now |
AltamashShaikh
left a comment
AltamashShaikh
left a comment
There was a problem hiding this comment.
Left some comments around translation reuse
@AltamashShaikh Thank you for educating me :) Could you please check again? The only difference is that General_LearnMore is not capitalised, I thought about doing a .toUpperCase, but have a feeling that might not work well with certain translations |
vue/src/EditAlert/EditAlert.vue
Outdated
| }, | ||
| getDeliveryMediumInlineTooltip(): string { | ||
| const link = translate( | ||
| 'General_LearnMore', |
There was a problem hiding this comment.
@lachiebol If we need it to be capitalized, we can add the Learnmore in the plugin translation file, like CustomAlerts_LearnMore you can check with Stan.
vue/src/EditAlert/EditAlert.vue
Outdated
| externalLink('https://matomo.org/faq/general/create-and-manage-custom-alerts/'), | ||
| '</a>', | ||
| ); | ||
| return `${translate('CustomAlerts_CreateTooltip')} ${link}`; |
There was a problem hiding this comment.
Do we need a fulltstop at the end ?
AltamashShaikh
left a comment
AltamashShaikh
left a comment
There was a problem hiding this comment.
Left few minor comments, rest looks good to me 👍
|
@AltamashShaikh Just changed it to be capitalised |
2 participants
Description
Added tooltips in add/edit alerts, manage alerts & in the inline text for the delivery method field
Issue No
Steps to Replicate the Issue
Checklist