Skip to content

Fix /my-library production errors and show public playlists#822

Open
marcodejongh wants to merge 2 commits intomainfrom
fix/my-library-production-errors
Open

Fix /my-library production errors and show public playlists#822
marcodejongh wants to merge 2 commits intomainfrom
fix/my-library-production-errors

Conversation

@marcodejongh
Copy link
Owner

Summary

  • Fix hydration mismatch (React fix: Fix queue sync validation errors in party mode #418): Added hasMounted state guard in library-page-content.tsx so SSR and initial client render produce identical HTML (loading state)
  • Fix playlist fetch error: Switched useClimbActionsData from GET_USER_PLAYLISTS (requires boardType/layoutId) to GET_ALL_USER_PLAYLISTS (no required params), added guards for boardName-dependent queries
  • Fix useBoardProvider outside BoardProvider: Added useOptionalBoardProvider() hook that returns null instead of throwing; updated queue-list.tsx, queue-list-item.tsx, and use-queue-data-fetching.tsx
  • Show public playlists for non-auth users: Replaced full-page sign-in block with compact banner; Discover section is now always visible

Test plan

  • Visit /my-library when NOT logged in — see compact sign-in banner + Discover section with public playlists
  • Visit /my-library/playlist/[uuid] when NOT logged in — public playlist detail page loads
  • Visit /my-library when logged in — see personal playlists + Jump Back In + Discover
  • No hydration error (fix: Fix queue sync validation errors in party mode #418) in console
  • No useBoardProvider error in console
  • On a board page, "Add to Playlist" shows all playlists (not just current board's)
  • Queue functionality on board routes still works

🤖 Generated with Claude Code

marcodejongh and others added 2 commits February 13, 2026 15:32
Delete dead Aurora proxy routes (blocked by App Attest), old sync cron,
and shared-sync. Switch frontend callers for profile, credentials,
controllers, and favorites to use existing GraphQL resolvers. Create new
backend GraphQL resolvers for beta links, climb stats, hold
classifications, user board mappings, unsynced counts, setter stats, and
hold heatmap. Remove ~30 Next.js API route files and orphaned utilities,
reducing the web package by ~3600 lines.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…uth users

- Fix hydration mismatch (#418) by adding hasMounted guard in library-page-content
- Switch useClimbActionsData to GET_ALL_USER_PLAYLISTS to avoid empty boardType/layoutId errors
- Add useOptionalBoardProvider hook so queue components don't throw outside BoardProvider
- Replace full-page sign-in block with compact banner, show Discover for all users

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@vercel
Copy link

vercel bot commented Feb 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
boardsesh Error Error Feb 13, 2026 2:45pm

Request Review

@claude
Copy link

claude bot commented Feb 13, 2026

Claude Review

Ready to merge - Minor issue noted below, but nothing blocking.

Issues

  1. Bug: Inconsistent property name - packages/web/app/components/beta-videos/beta-videos.tsx:173

    The condition uses foreign_username (old snake_case API format) while the value uses foreignUsername (new camelCase GraphQL format). The type is now BetaLink from @boardsesh/shared-schema which uses foreignUsername. This should be fixed to use foreignUsername consistently.

Notes

  • Large refactor migrating ~20 REST API routes to GraphQL backend
  • Added useOptionalBoardProvider() hook to avoid throwing errors when used outside BoardProvider
  • Added hasMounted guard in library page to fix hydration mismatch (React fix: Fix queue sync validation errors in party mode #418)
  • Removed Vercel cron jobs for shared-sync and user-sync (these should be handled elsewhere now)
  • Tests deleted with validation.test.ts - validation logic moved to backend schemas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant