Open
Conversation
| if (!this.options.phantomPath) this.options.phantomPath = phantomjs && phantomjs.path | ||
| this.options.phantomArgs = this.options.phantomArgs || [] | ||
| this.options.phantomArgs = this.options.phantomArgs.map(function (elt) { | ||
| if (elt.substring(0, 2) !== '--') { |
Owner
There was a problem hiding this comment.
IMO that's too much magic. I'd support --phantomArgs "--ignore-ssl-errors=yes". Then you'll also get a string in here and we can just split it
Author
There was a problem hiding this comment.
I agree with you, it would be better but unfortunately it does not work like this.
The double quotes are not kept and yargs-parser consider it as a normal argument.
|
Is this feature committed to latest release? |
Author
|
No. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to handle PhantomJS arguments the better way I could think of.
I you have better ideas, please tell me.