Open
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Docling dataset conversion timing benchmarks to include TIFF and PNG image samples, providing a more comprehensive performance comparison with markitdown. The updates reflect improved performance results and expand the test coverage beyond PDF files.
Key Changes:
- Added timing data for TIFF and PNG image file processing
- Updated PDF timing results with improved performance metrics
- Enhanced the comparison section to include image format timings against markitdown benchmarks
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| ## Docling data conversion timings | ||
|
|
||
| The following timings were captured while converting the PDF samples from Docling's `tests/data` directory. Image samples (TIFF and PNG) could not be processed in this environment because the Leptonica runtime was unavailable. | ||
| The following timings were captured while converting the PDF, TIFF and PNG samples from Docling's `tests/data` directory. |
There was a problem hiding this comment.
[nitpick] Missing Oxford comma before 'and PNG'. Should be 'PDF, TIFF, and PNG samples'.
Suggested change
| The following timings were captured while converting the PDF, TIFF and PNG samples from Docling's `tests/data` directory. | |
| The following timings were captured while converting the PDF, TIFF, and PNG samples from Docling's `tests/data` directory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
~/.dotnet/dotnet build~/.dotnet/dotnet testhttps://chatgpt.com/codex/tasks/task_e_689c22f8b69c83259ee3140bbd1c08f8