Open
Conversation
Also don't run bootstrap.sh from setup.py, instead assume that Mason and required packages have already been installed (with bootstrap.sh or otherwise).
- git submodule update when needed - remove unused var JOBS (it shouldn't be in "env" even if it were used, because changing "env" vars invalidates cache) - install clang from apt instead of mason - try common workaround for distutils bugs, without branching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes
setup.pyreads environment variablesMASON_ROOTandMAPNIK_CONFIG, which can be used to override these paths; defaults remained as beforesetup.pyno longer callsbootstrap.sh; it must be explicitly called earlierbootstrap.shno longer runs postgres, createdb etc.; database initialization has been moved toscripts/setup_postgres.shscripts/setup_mason.shnow tries to update submodule first; if that's not possible, falls back to downloading archive as beforeTODO
./bootstrap.sh