Removed unnecessary code to handle start point in lineSliceAlong()#1631
Merged
Removed unnecessary code to handle start point in lineSliceAlong()#1631
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1631 +/- ##
============================================
+ Coverage 79.23% 79.35% +0.11%
- Complexity 1128 1129 +1
============================================
Files 162 162
Lines 4701 4698 -3
Branches 660 659 -1
============================================
+ Hits 3725 3728 +3
+ Misses 706 702 -4
+ Partials 270 268 -2
🚀 New features to boost your workflow:
|
DzmitryFomchyn
previously approved these changes
Feb 5, 2026
6c24e12 to
a62f863
Compare
DzmitryFomchyn
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed code which could never occur when calculating the initial point in
lineSliceAlong().Given that
travelled > startDistthendouble overshot = startDist - travelledcould never be 0.Also added a test to validate when
travelled == stopDist.