Skip to content

refactor(dot-pattern)#894

Open
darka1pha wants to merge 1 commit intomagicuidesign:mainfrom
darka1pha:dot-pattern-performance
Open

refactor(dot-pattern)#894
darka1pha wants to merge 1 commit intomagicuidesign:mainfrom
darka1pha:dot-pattern-performance

Conversation

@darka1pha
Copy link

optimize rendering by using SVG pattern and remove unnecessary state management

@vercel
Copy link

vercel bot commented Feb 22, 2026

@darka1pha is attempting to deploy a commit to the product-studio Team on Vercel.

A member of the Team first needs to authorize it.

@Yeom-JinHo
Copy link
Member

Yeom-JinHo commented Mar 2, 2026

@darka1pha
This optimization looks good, but it introduces a backward-compatibility regression: the previous API relied on fill="currentColor" + text-* classes (e.g. className="text-red-500").

With fill-neutral-400/80 and no currentColor on <circle>, existing color overrides break.

Could we keep <circle fill="currentColor" /> and use text-neutral-400/80 as the default class so existing usage stays fully backward-compatible?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants