Workaround to fix semicolon syntax issue with keyframes#140
Open
arbylee wants to merge 1 commit intomadebysource:masterfrom
Open
Workaround to fix semicolon syntax issue with keyframes#140arbylee wants to merge 1 commit intomadebysource:masterfrom
arbylee wants to merge 1 commit intomadebysource:masterfrom
Conversation
Author
Context: Lessc is adding a semicolon at the end of keyframes definition, which is invalid css and causes issues on some devices. This also creates issues if you use anything that parses your css. This adds a noop rule at the end of each keyframes definition, leading to valid css
|
@arbylee problem with @-webkit-keyframes too. you fix in @Keyframes... but not in @-webkit-keyframes |
|
I'm currently using your fix so my grunt compiles correctly. I suscribed to this thread so I can port my lesshat version when this is merged. Thanks, @arbylee. |
|
Thanks arbylee, your fix works perfectly. The extra colon a the top of a css file was causing htc one "not understand" some following css rules! |
|
nice one, will it be merged, or will there be another fix? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: Lessc is adding a semicolon at the end of keyframes definition, which is
invalid css and causes issues on some devices. This also creates issues
if you use anything that parses your css such as grunt-cache-bust.
This adds a noop rule at the end of each keyframes definition, leading
to valid css