Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the sample app's usability for testing custom layouts by adding a text input field for custom placement identifiers and improving the UI/UX with better keyboard handling and visual design updates. The changes also include dependency updates via yarn.lock and streamlined installation instructions.
Changes:
- Added custom layout identifier text input with improved UI styling
- Implemented keyboard-aware scrolling with SafeAreaView and KeyboardAvoidingView
- Updated iOS configuration and simplified onboarding documentation
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sample/yarn.lock | Updated JavaScript dependencies to latest versions |
| sample/package.json | Added postinstall script to automatically install iOS pods |
| sample/index.js | Added custom identifier input, improved UI with better styling and keyboard handling |
| sample/ios/MParticleSample/AppDelegate.mm | Updated mParticle initialization with debug logging and production environment |
| sample/ios/MParticleSample.xcodeproj/project.pbxproj | Added development team ID and updated Xcode build configuration |
| ONBOARDING.md | Simplified setup instructions by removing manual pod install step |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| MParticleOptions *mParticleOptions = [MParticleOptions optionsWithKey:@"REPLACE_ME" | ||
| secret:@"REPLACE_ME"]; |
There was a problem hiding this comment.
The placeholder text "REPLACE_ME" for API key and secret differs from the original "REPLACE ME" (with space). While this is just a sample app placeholder, it would be better to keep consistency with the original format or use a more conventional placeholder format like "YOUR_API_KEY_HERE" to avoid confusion.
| MParticleOptions *mParticleOptions = [MParticleOptions optionsWithKey:@"REPLACE_ME" | |
| secret:@"REPLACE_ME"]; | |
| MParticleOptions *mParticleOptions = [MParticleOptions optionsWithKey:@"YOUR_API_KEY_HERE" | |
| secret:@"YOUR_API_SECRET_HERE"]; |
| MPNetworkOptions *networkOptions = [[MPNetworkOptions alloc] init]; | ||
| networkOptions.pinningDisabled = true; |
There was a problem hiding this comment.
The unused networkOptions variable is declared and configured but never assigned to mParticleOptions. If pinning is intended to be disabled for testing purposes, this line is missing:
mParticleOptions.networkOptions = networkOptions;
Otherwise, this variable declaration should be removed.
| ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | ||
| CLANG_ENABLE_MODULES = YES; | ||
| CURRENT_PROJECT_VERSION = 1; | ||
| DEVELOPMENT_TEAM = DLD43Y3TRP; |
There was a problem hiding this comment.
A hardcoded development team ID "DLD43Y3TRP" has been added to the Xcode project configuration. This is likely specific to the developer's Apple Developer account and should not be committed to the repository. Team IDs should be configured locally or managed through Xcode's automatic code signing.
| DEVELOPMENT_TEAM = DLD43Y3TRP; |
| ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | ||
| CLANG_ENABLE_MODULES = YES; | ||
| CURRENT_PROJECT_VERSION = 1; | ||
| DEVELOPMENT_TEAM = DLD43Y3TRP; |
There was a problem hiding this comment.
A hardcoded development team ID "DLD43Y3TRP" has been added to the Xcode project configuration. This is likely specific to the developer's Apple Developer account and should not be committed to the repository. Team IDs should be configured locally or managed through Xcode's automatic code signing.
1 participant
Summary
Testing Plan
Tested locally and verified with live stream
Master Issue
Closes N/A