feat: configure CI environment to talk to LocalStack#62
Open
Conversation
simonrw
force-pushed
the
feat/configure-environment
branch
from
93cdb40 to
d88b62f
Compare
|
The ephemeral instance for the application preview has been shut down |
simonrw
force-pushed
the
feat/configure-environment
branch
2 times, most recently
from
c4a678e to
1518c68
Compare
simonrw
force-pushed
the
feat/configure-environment
branch
from
1518c68 to
f40f241
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When using the
setup-localstackaction, the user currently has to setAWS_ENDPOINT_URLto target LocalStack. This is inconvenient - if we are providing a helper action to configure LocalStack then we should set the CI environment as well.Changes
AWS_ENDPOINT_URLby default tohttp://localhost.localstack.cloud:4566Thanks @dfangl for the idea!