fix: correct stderr logger level from ERROR to WARNING#3797
Open
gambletan wants to merge 1 commit intolm-sys:mainfrom
Open
fix: correct stderr logger level from ERROR to WARNING#3797gambletan wants to merge 1 commit intolm-sys:mainfrom
gambletan wants to merge 1 commit intolm-sys:mainfrom
Conversation
The stderr StreamToLogger was set to logging.ERROR, which means stderr output was logged at ERROR level. This is incorrect because stderr contains warnings and informational messages too. Changed to WARNING level which better matches stderr's typical content. Also set stderr_logger base level to INFO (matching stdout_logger) so that WARNING-level messages are not filtered out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stderr_loggerlevel inbuild_logger()fromERRORtoINFO(matchingstdout_logger)StreamToLoggerfor stderr fromlogging.ERRORtologging.WARNINGto properly reflect stderr's typical contentDetails
In
fastchat/utils.py, thebuild_logger()function sets up stream redirection for both stdout and stderr. The stdout logger correctly usesINFOlevel, but stderr was usingERRORfor both the logger level and the StreamToLogger level.This means:
transformers,torch, etc.) gets logged as ERRORstderr_logger.setLevel(logging.ERROR)filters out anything below ERROR, so WARNING-level messages from stderr would be silently droppedThe fix:
stderr_logger.setLevel(logging.INFO)— matches stdout_logger, allows all messages throughStreamToLogger(stderr_logger, logging.WARNING)— logs stderr at WARNING level, which is the appropriate severity for stderr contentTest plan
python -c "from fastchat.utils import build_logger; logger = build_logger('test', 'test.log')"to confirm no regressions🤖 Generated with Claude Code