add compressed_payload field to both RpcRequest and RpcResponse#1403
Open
xianshijing-lk wants to merge 2 commits intomainfrom
Open
add compressed_payload field to both RpcRequest and RpcResponse#1403xianshijing-lk wants to merge 2 commits intomainfrom
xianshijing-lk wants to merge 2 commits intomainfrom
Conversation
|
boks1971
reviewed
Feb 7, 2026
| uint32 response_timeout_ms = 4; | ||
| uint32 version = 5; | ||
| // Compressed payload data. When set, this field is used instead of `payload`. | ||
| bytes compressed_payload = 6; |
Contributor
There was a problem hiding this comment.
Is an alternative a possible consideration? A field like
enum Encoding {
BASE64 = 0; --> to ensure default remains the same
COMPRESSION_TYPE_1 = 1;
COMPRESSION_TYPE_2 = 2;
}
This allows an extensible format and we can have any encoding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So that we don't need to use base64 to encode the string, which adds 33% of overhead