You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Aug 31, 2021. It is now read-only.
OK, so here's something that's really confusing: revIDEObjectsAreSelectable is used to determine whether you can cut/clear objects through the contextual menu at the moment. But how do you pop up a contextual menu if the object is not selectable? Also, revIDEObjectsAreSelectable is incorrect to say that its function is to
Determine if a list of objects are selectable using the select command
As you can group a button, turn selectGroupedControls off and do select button 1 just fine.
Given that it is only used for contextual menus and is a guard against failure of revIDESelectObjects (which is how the implementations of the picked functions work - i.e. select and then perform action, I think we can potentially get rid of revIDEObjectsAreSelectable, or at least its use in the menu bar context menu stuff. Unless something somewhere else in the IDE relies on either of these...
Hmm revIDEObjectsAreSelectable could just have the same owner check removed as long as selectGroupedControls is not changed before revIDESelectObjects. Then it still guards against un-open controls or selecting across stacks etc. Of course if we change the implementation of cut, copy and clear to not involve selection then we don't have any of these concerns although we would have to expose the serialised object format to script in order to implement cut and copy that way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.