Backwards compatibility#1
Open
ghostal wants to merge 2 commits intolittlebizzy:1.0.6from
ghostal:backwards-compatibility
Open
Backwards compatibility#1ghostal wants to merge 2 commits intolittlebizzy:1.0.6from ghostal:backwards-compatibility
ghostal wants to merge 2 commits intolittlebizzy:1.0.6from
ghostal:backwards-compatibility
Conversation
Member
|
Thanks for the feedback Alex, however, our plugins have never claimed to support anything other than PHP version 7.0 (any other compatibility is simply coincidental). We follow WordPress version/branches so don't have a good way to merge pull requests yet. However we will review this for next version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your work on this plugin!
With the most recent update, the short syntax for PHP arrays breaks PHP 5 installs. These changes fix it again.
Dropping support for PHP 5 at this stage is pretty reasonable, but I'd suggest bumping the major version if the plan is to no longer support it, as it's a breaking change for sites still running on PHP 5.