-
Notifications
You must be signed in to change notification settings - Fork 2
Enrich rustdoc across public API surface #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alltheseas
wants to merge
5
commits into
lightningdevkit:master
Choose a base branch
from
alltheseas:enrich-rustdoc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
d9a23e3
Enrich rustdoc on core public API types and Wallet methods
alltheseas 8e2d4fb
Enrich rustdoc on Event enum and EventQueue
alltheseas 459afbe
Enrich rustdoc on Transaction, PaymentId, TxStatus, and PaymentType
alltheseas 436a29d
Enrich rustdoc on trusted_wallet module and backends
alltheseas ccf3a7f
Enrich graduated-rebalancer crate docs and add Cashu section to README
alltheseas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -138,20 +138,49 @@ The wallet's behavior is controlled by `Tunables`: | |
| ## Supported Backends | ||
|
|
||
| ### Trusted Wallet Backends | ||
| - **Spark** - Custodial Lightning wallet (default) | ||
| - **Cashu** - Ecash-based wallet | ||
|
|
||
| #### Spark (default) | ||
|
|
||
| Spark uses the [Breez Spark SDK](https://breez.technology) for custodial Lightning payments with instant settlement and low fees. This is the default backend and is enabled via the `spark` feature flag. | ||
|
|
||
| ```rust,no_run | ||
| use orange_sdk::trusted_wallet::spark::SparkWalletConfig; | ||
| use orange_sdk::ExtraConfig; | ||
|
|
||
| let extra = ExtraConfig::Spark(SparkWalletConfig::default()); | ||
| ``` | ||
|
|
||
| #### Cashu | ||
|
|
||
| Cashu uses the [Cashu Development Kit (CDK)](https://docs.rs/cdk) for ecash-based custody via a Cashu mint. Enable it with the `cashu` feature flag: | ||
|
|
||
| ```toml | ||
| [dependencies] | ||
| orange-sdk = { version = "0.1", features = ["cashu"] } | ||
| ``` | ||
|
|
||
| ```rust,ignore | ||
| use orange_sdk::trusted_wallet::cashu::CashuConfig; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: this can be |
||
| use orange_sdk::{CurrencyUnit, ExtraConfig}; | ||
|
|
||
| let extra = ExtraConfig::Cashu(CashuConfig { | ||
| mint_url: "https://mint.example.com".to_string(), | ||
| unit: CurrencyUnit::Sat, | ||
| npubcash_url: Some("https://npub.cash".to_string()), // optional: enables Lightning address | ||
| }); | ||
| ``` | ||
|
|
||
| ### Chain Sources | ||
| - Electrum servers | ||
| - Esplora servers (with optional Basic auth) | ||
| - Bitcoin Core RPC | ||
| - **Electrum** servers (use `ssl://` prefix for TLS) | ||
| - **Esplora** HTTP API servers (with optional Basic auth) | ||
| - **Bitcoin Core RPC** (direct JSON-RPC connection) | ||
|
|
||
| ## Documentation | ||
|
|
||
| For detailed API documentation, run: | ||
|
|
||
| ```bash | ||
| cargo doc --open | ||
| cargo doc --all-features --open | ||
| ``` | ||
|
|
||
| ## Contributing | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this can be
use orange_sdk::SparkWalletConfig