Add more integrity checks for tetrahedralization#4408
Open
roystgnr wants to merge 4 commits intolibMesh:develfrom
Open
Add more integrity checks for tetrahedralization#4408roystgnr wants to merge 4 commits intolibMesh:develfrom
roystgnr wants to merge 4 commits intolibMesh:develfrom
Conversation
Member
Author
|
I'm putting this up to make sure it doesn't trigger any false positives in downstream CI and to give @GiudGiud a chance to play with it right away, but leaving it as "Draft" until I find time to add some unit tests for it. |
roystgnr
force-pushed
the
more_hull_integrity_checks
branch
2 times, most recently
from
487d99e to
36864cd
Compare
Member
Author
|
@GiudGiud reports that this finally was enough to catch the mixed orientation in his input. I'm going to tack on some commits to fix those problems, not just to test the tests for them, but this should be ready to review/merge at any time; I could add later work to a different PR instead. |
An integer error code was kind of lazy of us, and using a set lets us cleanly fix errors rather than just report them.
This might be useful in letting application code recover from such errors, and it's definitely useful in debugging unit tests where I've screwed something up.
roystgnr
force-pushed
the
more_hull_integrity_checks
branch
from
36864cd to
55a5fef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopefully this will catch whatever's going wrong on Guillaume's test case; I'm terrified of the possibility of having to diagnose a Netgen bug.