Header only file and workflow update#1023
Open
KalanaRatnayake wants to merge 7 commits intoleethomason:masterfrom
Open
Header only file and workflow update#1023KalanaRatnayake wants to merge 7 commits intoleethomason:masterfrom
KalanaRatnayake wants to merge 7 commits intoleethomason:masterfrom
Conversation
KalanaRatnayake
commented
Apr 28, 2025
- Combined "tinyxml2.cpp" and "tinyxml2.h" into "tinyxml2.hpp" which is a header only file for easier integration into ROS projects. Merging is done by copying the content directly and merging the namespaces. Changes are kept minimum (more optimizations can be done but not performed) due to easier future maintenance.
- Updated and formatted the Makefile to include additional test "xmltest2.cpp" that testes the new header file
- Updated CMakeLists.txt to include additional test "xmltest2.cpp"
- Updated ReadMe.md to include info about new file
- Updated workflow by removing ubuntu 20.04 because github have removed the runners
- Updated workflow by adding ubuntu 22.04 and 24.04 because github have added the runners
- Verified new file passes all the tests (makefile based, cmakelists.txt based and gitworkflow based)
…med xmltest2.cpp with makefile modifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.