Fix: Correct handling of import module as alias in LPython semantic analysis#2872
Open
amritamishra01 wants to merge 6 commits intolcompilers:mainfrom
Open
Fix: Correct handling of import module as alias in LPython semantic analysis#2872amritamishra01 wants to merge 6 commits intolcompilers:mainfrom
import module as alias in LPython semantic analysis#2872amritamishra01 wants to merge 6 commits intolcompilers:mainfrom
Conversation
Author
|
Subject: Clarifying the CI Failure Hi @certik , I noticed the CI checks are failing on the macOS-latest build, but all other 17/18 test cases are passing. It looks like the failure might be related to the known default Mac environment issue rather than my changes. Could you please confirm if this requires any action on my end? If not, I'm ready to address any other review feedback you might have. Thanks! |
c2a3d42 to
78abfa6
Compare
Author
|
Update: Rebased on the latest main and all CI checks are now passing (18/18). I have verified the fix locally and confirmed the tests pass on the CI. This is ready for final review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where import statements with aliases (e.g.,
import numpy as np) would load the module correctly but fail to register the alias (np) in the current scope. As a result, subsequent code using the alias (likenp.array()) would fail withNameError: 'np' is not defined.This patch updates the semantic analysis phase to ensure import aliases are correctly created and installed into the symbol table as
ExternalSymbols.Technical Changes
visit_Importinsrc/lpython/semantics/python_ast_to_asr.cpp:x.m_names[i].m_asname) to be lost before the symbol registration step.ASR::ExternalSymbol_tin the current scope.np) to the loaded module symbol (e.g.,numpy), mirroring Python's behavior.Verification
I verified the fix using the following reproduction script
repro.py: