Fix CI Failures and Improve Test Code#283
Merged
lucdion merged 13 commits intolayoutBox:masterfrom Jul 23, 2025
Merged
Conversation
…eAreaInsets test cases
heoblitz
commented
Jul 20, 2025
| CI: | ||
| runs-on: macos-latest | ||
|
|
||
| runs-on: macos-15 |
Contributor
Author
There was a problem hiding this comment.
Update the CI Xcode version to 16.4.
| # -scheme PinLayout-macOS \ | ||
| # -sdk macosx \ | ||
| # -destination "platform=macOS,name=Any Mac" \ | ||
| # | xcpretty |
Contributor
Author
There was a problem hiding this comment.
Test compilation fails with the current project structure. For now, I have fixed the existing test code to make it work, but further improvements should be addressed in a separate PR.
lucdion
reviewed
Jul 21, 2025
Member
lucdion
left a comment
lucdion
left a comment
There was a problem hiding this comment.
Once you have fixed already identified issues, it is very good improvement 👏
Contributor
Author
|
I’ll fix the identified issues and also include Mac and tvOS tests in this PR 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR?
Fix CI Failures and Improve Test Code.
The runner image uses the latest version, but since Xcode 13 is not available, the CI fails.
→ Specify the macOS version and manage test devices using environment variables.
Currently, the tests depend on the iPhone SE device.
→ Improved the test code to ensure that tests work correctly on devices with different top and bottom safe areas.