Add isIncludedInPinLayoutSizeCalculation property to Layoutable#268
Open
stleamist wants to merge 5 commits intolayoutBox:masterfrom
Open
Add isIncludedInPinLayoutSizeCalculation property to Layoutable#268stleamist wants to merge 5 commits intolayoutBox:masterfrom
isIncludedInPinLayoutSizeCalculation property to Layoutable#268stleamist wants to merge 5 commits intolayoutBox:masterfrom
Conversation
stleamist
force-pushed
the
feature/is-included-in-pin-layout
branch
from
152b8b6 to
cbb1684
Compare
stleamist
changed the title
isIncludedInPinLayout property to LayoutableisIncludedInPinLayoutSizeCalculation property to Layoutable
Author
|
Hi @lucdion, I've made a proposal to exclude subviews from the size calculation without removing them. I'd appreciate it if you could review it! :) |
stleamist
force-pushed
the
feature/is-included-in-pin-layout
branch
from
cbb1684 to
38bbd92
Compare
lucdion
reviewed
May 16, 2023
| **`wrapContent(padding: CGFloat)`** | ||
| **`wrapContent(padding: UIEdgeInsets)`** | ||
| Adjust the view's width and height to wrap all its subviews. The method also adjusts subviews's position to create a tight wrap. It is also possible to specify an optional padding around all subviews. | ||
| Adjust the view's width and height to wrap all its subviews that are included in the layout. The method also adjusts subviews's position to create a tight wrap. It is also possible to specify an optional padding around all subviews. |
Member
There was a problem hiding this comment.
You should add an URL link that point to the documentation of the new property for the string are included in the layout
| * **`wrapContent(:WrapType)`** | ||
| **`wrapContent(:WrapType, padding: CGFloat)`** **`wrapContent(:WrapType, padding: UIEdgeInsets)`** | ||
| Adjust the view's width AND/OR height to wrap all its subviews. Accept a WrapType parameter to define the wrapping type. It is also possible to specify an optional padding around all subviews. | ||
| Adjust the view's width AND/OR height to wrap all its subviews that are included in the layout. Accept a WrapType parameter to define the wrapping type. It is also possible to specify an optional padding around all subviews. |
stleamist
force-pushed
the
feature/is-included-in-pin-layout
branch
from
7a35f5b to
7afd896
Compare
Member
|
Just missing changes related to the documentation 🙏 |
Author
|
I'll let you know when the documentation is complete! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
isIncludedInPinLayoutSizeCalculationproperty toLayoutable.This can be useful when calculating the size of a view that contains subviews that may disappear based on conditions after the initial load. (similary to
UIStackView'sarrangedSubviews, orFlexLayout'sisIncludedInLayout)