Create multiple track segments when tracking is stopped and later res…#591
Create multiple track segments when tracking is stopped and later res…#591AlainKnaff wants to merge 8 commits intolabexp:developfrom
Conversation
…umed to avoid criss-crossing lines on map
|
Hello @AlainKnaff , could you pass the pr to the develop branch? |
|
How do I do that? |
|
Ok, found it |
|
Is this still on your radar, or is there anything what I still need to be doing here? |
|
I'll review your PR. |
Thanks |
| * atmospheric pressure | ||
| */ | ||
| public void track(long trackId, Location location, float azimuth, int accuracy, float pressure) { | ||
| public void track(long trackId, Location location, float azimuth, int accuracy, float pressure, boolean newSeg, long segId) { |
There was a problem hiding this comment.
Var newSeg is never used in this method; please delete it.
| */ | ||
| private PressureListener pressureListener = new PressureListener(); | ||
|
|
||
| private boolean newSeg = false; |
There was a problem hiding this comment.
Var newSeg isn't really used in this file. It can be deleted.
|
Thanks for your work on this PR! It's a valuable contribution to OSMTracker 🚀 I started the review and commented a little, but the PR has some conflicts with the latest changes in the |
|
If you don't mind, I created a branch in my repo to help resolve the conflicts and suggest some improvements and then open a pull request against your branch. |
|
Ok, so I fixed the newSeg issue (which turned out to be a leftover from an earlier version of the change). Anything else that needs to be done? If so, what concrete steps do I need to perform to solve the issue (if there is any issue left)? Thanks |
|
Due to the delay in reviewing and merging it, the Git history of the PR got a little messy. It requires rebases and conflict solving, so I took the original commit with the contribution (thanks to @AlainKnaff), cherry-picked it to a branch created from develop, and opened a PR ready to be merged. So, I'll close this one. |
4 participants
…umed to avoid criss-crossing lines on map
Description
Hi,
This pull pull request is an update of (#310) ("Track segments" when tracking is stopped and later resumed)
This PR resolves the conflicts with the dev branch (newest osmdroid that uses Polylines) which prevented the eal
It also associates consecutive segment numbers with each segment, rather than marking the first point of each segment.
Thx for merging,
Alain
Related issues
#295
Pull Request Checklist