-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add pull-ingress2gateway-e2e #36223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add pull-ingress2gateway-e2e #36223
Conversation
Signed-off-by: Johanan Liebermann <jliebermann@microsoft.com>
|
Hi @johananl. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: johananl The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Depends on merging kubernetes-sigs/ingress2gateway#294. I'm not sure if we can test the Prow job against an unmerged PR. /hold |
|
/unhold |
| resources: | ||
| limits: | ||
| cpu: 1 | ||
| memory: 4Gi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how much memory we need for this kind of job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depends on how much parallelism we give it.
|
/ok-to-test |
|
@Stevenjin8: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR adds an e2e job for ingress2gateway.
I've set
always_run: falseandskip_report: truefor now until we have confidence in the job.