test: make contexthelper timeout tests deterministic #136733
Open
+37
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind flake
What this PR does / why we need it:
Makes context timeout handling and tests deterministic by avoiding logging from a goroutine, safely stopping/draining timers, waiting for goroutine completion in cleanup, and waiting for actual context cancellation in tests to reduce flakiness.
Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Stabilizes contexthelper_test.go by replacing time-based sleeps with cancellation-based waits; reduces timing-related flakes.
Does this PR introduce a user-facing change?
NONE
https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/ci-kubernetes-unit-ppc64le/1994147797376438272
Flake