-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-5598: update for pod signature re-use optimization #5888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
KEP-5598: update for pod signature re-use optimization #5888
Conversation
|
Welcome @romanbaron! |
|
Hi @romanbaron. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
60849c4 to
b93244b
Compare
| kep-number: 5598 | ||
| beta: | ||
| approver: "@wojtek-t" | ||
| stable: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to stay in beta in v1.36. Please remove the stable graduation parts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
b93244b to
e29ca98
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: romanbaron The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to move stable at least two releases forward, so at least 1.37
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
|
/ok-to-test |
dom4ha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Roman. Can you check whether we don't need to update other parts? We have a week do so.
I think one of the things to update is signature interface.
The second is that we no longer use nomination, but plug directly into the scheduling cycle.
Co-authored-by: Dominik Marciński <gmidon@gmail.com>
Updated milestones and to stable stage towards v1.36 release.
Updated README with the optimization in PR #136579