Skip to content

Conversation

@sunya-ch
Copy link
Contributor

  • One-line PR description: Update beta milestone and add Troubleshooting and Metrics to meet beta criteria
  • Other comments: KEP-5075

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Jan 29, 2026
@k8s-ci-robot k8s-ci-robot requested review from dom4ha and macsko January 29, 2026 04:26
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 29, 2026
@haircommander haircommander mentioned this pull request Jan 29, 2026
12 tasks
@@ -24,12 +24,12 @@ see-also:
- "/keps/sig-scheduling/5007-device-attach-before-pod-scheduled"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need a new entry in keps/prod-readiness/sig-scheduling/5075.yaml as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haircommander Thank you so much! I have added just now.

@deads2k Could you please be an approver also in beta?

@dom4ha
Copy link
Member

dom4ha commented Jan 30, 2026

/approve for sig-scheduling

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dom4ha, sunya-ch
Once this PR has been reviewed and has the lgtm label, please assign kannon92 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dom4ha
Copy link
Member

dom4ha commented Jan 30, 2026

FYI @sanposhiho @macsko

@macsko
Copy link
Member

macsko commented Feb 2, 2026

Could you update the unit unit tests coverage?

Signed-off-by: Sunyanan Choochotkaew <sunyanan.choochotkaew1@ibm.com>
@sunya-ch
Copy link
Contributor Author

sunya-ch commented Feb 4, 2026

Could you update the unit unit tests coverage?

Thank you. I update the unit test section.

@macsko
Copy link
Member

macsko commented Feb 4, 2026

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

5 participants