Skip to content

KEP-127: Let's go GA in 1.36! #5847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rata wants to merge 3 commits into
base: master
Choose a base branch
from
Open

KEP-127: Let's go GA in 1.36! #5847

rata wants to merge 3 commits into from
+22 −38

Conversation

@rata
Copy link
Member

@rata rata commented Jan 28, 2026

  • One-line PR description: Move UsernamespaceSupport to GA in 1.36
  • Other comments:

cc @giuseppe @haircommander @saschagrunert @mrunalp

@rata
KEP-127: Remove old section
b205a2b 
The windows review link was deleted by mistake, but here it is just in
case:
	kubernetes#3275 (comment)

The VM runtimes can use this inside a VM or just ignore this field.

Signed-off-by: Rodrigo Campos <rodrigo@sdfg.com.ar>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jan 28, 2026
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jan 28, 2026
@k8s-ci-robot k8s-ci-robot requested a review from mrunalp January 28, 2026 16:09
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 28, 2026
giuseppe
giuseppe approved these changes Jan 28, 2026
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rata
Copy link
Member Author

rata commented Jan 28, 2026

@wojtek-t the PRR was already completed and is unchanged. Not sure if you want to have another check before we go GA.

@wojtek-t
Copy link
Member

wojtek-t commented Jan 28, 2026

You will need GA block and my approval for it in:
https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-node/127.yaml

so I will take another look, but as you mentioned it should already be in a good shape

@wojtek-t wojtek-t self-assigned this Jan 28, 2026
@rata
Copy link
Member Author

rata commented Jan 28, 2026

@wojtek-t oh, the beta migration was so long ago that I completely forgot that. Added now, thanks! Thanks for taking the time to review, all the way from alpha too! :)

cyphar
cyphar approved these changes Jan 28, 2026
View reviewed changes
Copy link

@cyphar cyphar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, finally! Thanks so much to everyone for all of the work (in the kernel, in userspace, in lower-level runtimes, in higher-level runtimes, and finally putting it together in Kubernetes) that went into this over the last decade. :shipit:

saschagrunert
saschagrunert approved these changes Jan 29, 2026
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2026
@haircommander
Copy link
Contributor

haircommander commented Jan 29, 2026

/lgtm

lmktfy
lmktfy reviewed Jan 29, 2026
View reviewed changes
keps/sig-node/127-user-namespaces/README.md
- Kubernetes 1.34: Feature adds metrics
- Kubernetes 1.36: Feature goes GA

## Drawbacks
Copy link
Member

@lmktfy lmktfy Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could actually remove this section

@haircommander haircommander mentioned this pull request Jan 30, 2026
Open
53 tasks
wendy-ha18
wendy-ha18 suggested changes Feb 3, 2026
View reviewed changes
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 3, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cyphar, giuseppe, mrunalp, rata, saschagrunert
Once this PR has been reviewed and has the lgtm label, please ask for approval from wojtek-t. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2026
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 3, 2026

New changes are detected. LGTM label has been removed.

wojtek-t
wojtek-t reviewed Feb 4, 2026
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some very minor comments from PRR POV. Other than that LGTM.

keps/sig-node/127-user-namespaces/README.md
<!--
**Note:** This checklist is iterative and should be reviewed and updated every time this enhancement is being considered for a milestone.
-->

Copy link
Member

@wojtek-t wojtek-t Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From PRR perspective:

Are there any tests for feature enablement/disablement?

The answer there requires some update, though it's probably too late for adding those now (especially given we're close to locking the gate anyway).
So I will not block on it at this point.

What specific metrics should inform a rollback?

"The following kubelet metrics will be added" - I see they were already added, so it would be good to update it to reflect it.

Are there any missing metrics that would be useful to have to improve observability of this feature?

Same comment about reflecting these were added.

Copy link
Member Author

@rata rata Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to reflect metrics were added. And regarding the tests, we had them already, added the links to them :)

See commit "KEP-127: Reflect metrics and tests we already added" for these changes :)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 4, 2026 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2026
rata added 2 commits February 4, 2026 13:08
@rata
KEP-127: Reflect metrics and tests we already added
b0faa71 
Signed-off-by: Rodrigo Campos <rodrigo@sdfg.com.ar>
@rata
KEP-127: Let's go GA in 1.36
04c5451 
This also updates to the latest KEP template, that was almost a no-op.
Just the comment about the checklist is iterative is the only change.

Signed-off-by: Rodrigo Campos <rodrigo@sdfg.com.ar>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@mrunalp mrunalp mrunalp approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

+4 more reviewers

@lmktfy lmktfy lmktfy left review comments

@wendy-ha18 wendy-ha18 wendy-ha18 requested changes

@giuseppe giuseppe giuseppe approved these changes

@cyphar cyphar cyphar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@saschagrunert saschagrunert

@haircommander haircommander

@wojtek-t wojtek-t

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@rata @wojtek-t @haircommander @k8s-ci-robot @mrunalp @giuseppe @saschagrunert @cyphar @wendy-ha18 @lmktfy