Skip to content

Conversation

@codeurluce
Copy link

@codeurluce codeurluce commented Jan 20, 2026

Fixes #624

When scrolling down, the sticky header currently has no background, causing underlying text to appear through it — reducing readability.

This PR:

  • Adds a semi-transparent Kubernetes blue background (rgba(26, 117, 255, 0.95)) to .td-navbar when scrolled
  • Uses a lightweight scroll listener to toggle the .scrolled class
  • Loads the script via Docsy's body-end.html hook

No build or Go knowledge required — pure frontend fix.

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 20, 2026
@k8s-ci-robot k8s-ci-robot requested a review from lmktfy January 20, 2026 13:16
@k8s-ci-robot
Copy link
Contributor

Welcome @codeurluce!

It looks like this is your first PR to kubernetes/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/contributor-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: codeurluce
Once this PR has been reviewed and has the lgtm label, please assign nimbinatus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 20, 2026
Copy link
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

It's very tidy; rarely do I see a first contribution that is so well aligned to how we work.

Until I properly test this I won't add LGTM, but I am happy to have this change merged.

}

.td-navbar.scrolled {
background-color: rgba(26, 117, 255, 0.95);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be able to reference $primary here (I haven't checked it this works), at 50% alpha.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion, @lmktfy! I've updated the background color to use the $primary SCSS variable for better consistency with the theme. 😊

@lmktfy
Copy link
Member

lmktfy commented Jan 25, 2026

Actually, #614

The technical work is good but the alignment to put overall aims isn't quite there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sticky header overlaps content during scroll — needs background for readability

3 participants