-
Notifications
You must be signed in to change notification settings - Fork 173
fix(header): add background on scroll to prevent content overlap #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(header): add background on scroll to prevent content overlap #625
Conversation
|
Welcome @codeurluce! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: codeurluce The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
lmktfy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR.
It's very tidy; rarely do I see a first contribution that is so well aligned to how we work.
Until I properly test this I won't add LGTM, but I am happy to have this change merged.
assets/scss/_styles_project.scss
Outdated
| } | ||
|
|
||
| .td-navbar.scrolled { | ||
| background-color: rgba(26, 117, 255, 0.95); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might be able to reference $primary here (I haven't checked it this works), at 50% alpha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion, @lmktfy! I've updated the background color to use the $primary SCSS variable for better consistency with the theme. 😊
|
Actually, #614 The technical work is good but the alignment to put overall aims isn't quite there. |
Fixes #624
When scrolling down, the sticky header currently has no background, causing underlying text to appear through it — reducing readability.
This PR:
rgba(26, 117, 255, 0.95)) to.td-navbarwhen scrolled.scrolledclassbody-end.htmlhookNo build or Go knowledge required — pure frontend fix.
/kind bug