-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Enable host network for the admission controller pod #9148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable host network for the admission controller pod #9148
Conversation
|
|
Welcome @PavelSazonovArammeem! |
|
Hi @PavelSazonovArammeem. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: PavelSazonovArammeem The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/ok-to-test |
|
/release-note-none |
|
The CLA needs signing: #9148 (comment) |
|
/close |
|
@adrianmoisey: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/kind feature
What this PR does / why we need it:
Adds optional
hostNetworkparameter to the VPA admission controller Helm chart. This allows users to enable host network mode when the admission controller pod needs direct access to the host's network namespace.Which issue(s) this PR fixes:
Fixes #9143
Special notes for your reviewer:
The parameter is optional and not set by default, allowing Kubernetes to use its default behavior (hostNetwork: false). This follows the existing pattern used for other optional parameters like
priorityClassName.Does this PR introduce a user-facing change?